Image Block: properly show errors on drag n drop #25004
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #21559
On error while dragging an image to the editor canvas set the
src
,id
,url
attributes toundefined
so that the placeholder which contains the errors is shown. It follows the same pattern as withaudio
block which works alreadygutenberg/packages/block-library/src/audio/edit.js
Line 61 in a610923
It kind of replicates #24398
How has this been tested?
Manually tested uploading an image that exceeds the size limit (eg > 2MB) and then uploading an image under the limit.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: