Polish horizontal movers. #25037
Merged
Polish horizontal movers. #25037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: +106 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
|
This PR definitely improves the horizontal movers and make them take just the space they need, which is great. Although I just noticed that the hovering moving animation of the icons have been implemented already for vertical movers in another PR and this IMO is a bit problematic. It seems to me a bit disorientating when hovering over for example up and then down. This triggers both What do you think? |
mtias
approved these changes
Sep 3, 2020
|
The transitions are an experiment, we can see if they hinder rather than aid the experience, and whether it should be only in the vertical version. |
|
I see this PR has the "Backport to WP Core" label; which release is it targeted at? |
|
It was meant to be something that could be added in any minor release as a small bug fix |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
|
Removed the label as it's on trunk now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the mover refactor, the spacing was not perfect for horizontal movers. This PR addresses that. Before:
After:
This also adds the same animation the vertical ones have.