Revert "InnerBlocks: introduce prop to specify render callback for each block." #25196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Type] Task
ZebulanStanphill
requested review from
ellatrix and
youknowriad
as code owners
10 tasks
|
Size Change: -162 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Sep 9, 2020
There was a problem hiding this comment.
While this is a good idea and the problem might pop up in the future, there currently is no application of this in progress. Let's revisit this later. Thanks for the great work @ZebulanStanphill ! 🙏
draganescu
deleted the
revert-24232-add/inner-blocks-child-wrapper-prop
branch
|
Thank you for both the initial effort and for this follow up! This is a slightly thorny issue that we should have a bit more real-world use cases in dance to make a better evaluation on its tradeoffs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #24232. I forgot to implement any parsing changes to support the InnerBlocks render callback API. This means that although everything would work fine initially in the editor and even upon save, if you exited and returned to the editor, it would not know how to parse blocks using the render callback feature.
Since I do not know how to finish implementing the experimental feature, I've created this PR to remove the broken API for now.