Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readme for the multi selection component #25306

Conversation

JustinyAhin
Copy link
Member

Description

Added documentation for the multi selector inspector component (see #22891)

How has this been tested?

N/A, documentation only

Types of changes

Documentation

Checklist:

  • [n/a] My code is tested.
  • [n/a] My code follows the WordPress code style.
  • [n/a] My code follows the accessibility standards.
  • [n/a] My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@JustinyAhin
Copy link
Member Author

@mkaz for the code sample, I'm wondering if I should rather do something like:

const SelectedBlockCount = getSelectedBlockCount();
if ( SelectedBlockCount > 1 ) {
    const MyMultiSelectionInspector = () => <MultiSelectionInspector />;
}

Maybe looks more clear?

@JustinyAhin JustinyAhin added the [Type] Developer Documentation Documentation for developers label Sep 14, 2020
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed a line to replace from your template.

Also your code example in the comment is better, maybe prefix with a description of "an example detecting multiple blocks to determine the component used" or something like that.

Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JustinyAhin JustinyAhin merged commit 5231ec9 into WordPress:master Sep 17, 2020
@github-actions github-actions bot added this to the Gutenberg 9.1 milestone Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants