Edit site: fix site base URL #25409
Merged
Edit site: fix site base URL #25409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
spacedmonkey,
TimothyBJacobs and
youknowriad
as code owners
aristath
approved these changes
Sep 17, 2020
|
Size Change: +24 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Sep 17, 2020
| @@ -18,7 +18,9 @@ const { fetch } = window; | |||
| */ | |||
| export default async function findTemplate( path, getEntityRecords ) { | |||
| const { data } = await fetch( | |||
There was a problem hiding this comment.
Shouldn't this use apiFetch instead? I believe it might solve the issue as well?
There was a problem hiding this comment.
We'd have to move the endpoints to use the REST API instead.
There was a problem hiding this comment.
I'm not sure this is a requirement for apiFetch?
There was a problem hiding this comment.
I see no option in apiFetch to change the root URL. In this case, the root URL would be the site URL instead of the REST API URL.
|
Too quick to merge :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm blocked by this issue because my test site is not installed on the top level domain, so merging as soon as it passes. Might be nice to try to use apiFetch in the future? I don't see why this cannot be done through the REST API...
How has this been tested?
Screenshots
Types of changes
Checklist: