-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'Publish sidebar Cancel button not usable through speech recognit… #25441
Fix 'Publish sidebar Cancel button not usable through speech recognit… #25441
Conversation
…ion software' issue
Hey, apologies for the check failures. I shall fix them. |
@afercia @allilevine, I have raised this PR related to the issue #25194. As mentioned in the PR post above, I have only been able to test it using 'Speech Recognition Anywhere' extension on Chrome browser on Windows machine. I request you to let me know about a suitable free software that could be used to test the feature. Also, I'm not sure whether this fix also required any changes in the React Native files. I also request you to let me know about the same. Thanks. |
👍 I tested with Voice Control and Safari (following the steps in #25194) and saying "Click cancel" closed the Publish panel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge!
@prashanttholia thanks for working on this! To answer your question, I'm not sure there are good speech recognition software for Windows that are free. Traditionally, the most used one is Dragon but it's commercial software and pretty expensive. On Windows 10, there's the built-in "Windows Speech Recognition" tool which can be used for testing, to some extent. Also to consider that different tools often give different results. For example, when testing with Voice Control on macOS and then with Windows Speech Recognition on Windows, I often get different behaviors. The PR looks good to me, the change is simple, and everything is green. Merging! |
Congratulations on your first merged pull request, @prashanttholia! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
Thanks @afercia! I did try testing "Windows Speech Recognition", but it somehow did not work on my machine. I am glad that the PR is being merged. Thanks to you and @allilevine for providing the opportunity to contribute! |
…ion software' issue
Related Issue: #25194
Description
Fixes the issue of publisher sidebar cancel button not being usable through speech recognition software.
How has this been tested?
Tested using Speech Recognition Anywhere extension on Chrome browser on Windows machine.
Types of changes
Bug fix: Fixes the issue of publisher sidebar cancel button not being usable through speech recognition software.
Checklist: