Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use esc_html rather than esc_attr for archives #25476

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Use esc_html rather than esc_attr for archives #25476

merged 1 commit into from
Sep 21, 2020

Conversation

audrasjb
Copy link
Contributor

Description

Fixes a wrong use of esc_attr in archives. esc_html should be preferred here. This was already fixed in core and should be fixed in Gutenberg too.
For reference, see https://core.trac.wordpress.org/ticket/50826

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@talldan talldan added the [Block] Archives Affects the Archives Block label Sep 21, 2020
aristath
aristath approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aristath aristath merged commit 9fd159f into WordPress:master Sep 21, 2020
@github-actions github-actions bot added this to the Gutenberg 9.1 milestone Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristath aristath aristath approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
[Block] Archives Affects the Archives Block
Projects
None yet
Milestone
Gutenberg 9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@audrasjb @aristath @talldan