-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove wp_area custom post type #25497
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Feature] Widgets Screen
The block-based screen that replaced widgets.php.
[Block] Legacy Widget
Affects the Legacy Widget Block - used for displaying Classic Widgets
[Package] Edit Widgets
/packages/edit-widgets
labels
Sep 21, 2020
adamziel
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
September 21, 2020 11:02
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
draganescu
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all right!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Legacy Widget
Affects the Legacy Widget Block - used for displaying Classic Widgets
[Feature] Widgets Screen
The block-based screen that replaced widgets.php.
[Package] Edit Widgets
/packages/edit-widgets
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #24674:
Just eyeballing the change should be enough. A more sophisticated test plan would be just going to the widgets editor, making a change, and clicking save.