Add aria-haspopup to the media flow Replace button #25597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellyworth
added
the
[Focus] Accessibility (a11y)
tellyworth
force-pushed
the
add/aria-haspopup-media-replace-flow
branch
from
c92f658 to
d1b2a14
Compare
oandregal
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the
aria-haspopupproperty to the Replace toolbar button in the MediaReplaceFlow component. See #24796 for details.How has this been tested?
Manual testing only: insert an image and inspect the Replace toolbar button. Ensure that it has
aria-haspopup=true.