Remove the block-based widgets editor from the customizer. #25626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Feature] Widgets Screen
adamziel
requested review from
spacedmonkey,
TimothyBJacobs and
youknowriad
as code owners
adamziel
force-pushed
the
update/remove-widgets-editor-from-customizer
branch
from
72b9967 to
73ee809
Compare
|
Size Change: -325 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
adamziel
changed the title
draganescu
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
I will approve this since the current state of the customizer in the Gutenberg plugin is broken and there is no clear path forward about how to fix that. With this patch, the normal widgets can still be edited in the customizer and the block ones don't break it anymore.
This is NOT to mean that we won't proceed with fixing the block editor in the customizer, that is still an ongoing discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #25625 - let's keep the discussion in that issue.
Removes the block-based widgets editor from the customizer and instead relies on the legacy editor featuring block-based widgets: