-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Widgets] Auto expand the last selected widget area when opening the inserter #25669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
An existing feature does not function as intended
[Feature] Widgets Screen
The block-based screen that replaced widgets.php.
labels
Sep 28, 2020
kevin940726
requested review from
ajitbohra,
Soean,
talldan and
youknowriad
as code owners
September 28, 2020 06:23
Size Change: +249 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
kevin940726
changed the title
[Widgets] Auto expand the first widget area when opening the inserter
[Widgets] Auto expand the last selected widget area when opening the inserter
Sep 28, 2020
adamziel
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks great and the PR works as intended - great job @kevin940726 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Widgets Screen
The block-based screen that replaced widgets.php.
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #25648 and fix #25650.
Auto expand the last selected widget area when opening the inserter.
Done it by registering a
@wordpress/data
statewidgetAreasOpenState
inedit-widgets
store. Potentially makes it easier to manage the open state in the future.This PR fixes two issues together since they are very similar and might be easier to understand when reviewing as a whole.
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist: