Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip: Use CSS-in-JS #25920

Closed
wants to merge 1 commit into from
Closed

Tip: Use CSS-in-JS #25920

wants to merge 1 commit into from

Conversation

sarayourfriend
Copy link
Contributor

Description

This PR updates the Tip component to use CSS-in-JS similar to how newer components do like the AnglePickerControl and Text.

How has this been tested?

I've confirmed there are no visual or behavioral differences between this branch and upstream in storybook.

Screenshots

Before:
Captura de Tela 2020-10-07 às 13 10 21

After:
Captura de Tela 2020-10-07 às 13 10 18

Types of changes

Non-breaking style change. The classname is preserved so it is still possible to target the components-tip class.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@sarayourfriend
Copy link
Contributor Author

Closing in favor of #26366

@sarayourfriend sarayourfriend deleted the refactor/use-css-in-js-for-tip branch October 21, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant