Gallery: Convert Gallery block to use Image blocks instead of having its own nested image format#25940

Merged

glendaviesnz merged 158 commits intotrunkfrom refactor/gallery-to-nested-image-blocks

Aug 19, 2021

+2,631-673

Commits on Apr 11, 2021

Refactor gallery to nested image blocks
Glen Davies
committed
Fix issue with images not loading on first selection from media gallery
Glen Davies
committed
Remove the default columns setting as we don't have access to innerBlocks at the point that the block validation is run
Glen Davies
committed
Revert "Remove the default columns setting as we don't have access to innerBlocks at the point that the block validation is run"
Glen Davies
committed
Add image count so we can work out default columns as innerBlocks not available at point of block validation
Glen Davies
committed
Disable the innerBlocks dropzones so drag drop works same as existing gallery - with the idea that we will improve the innerblocks drag and drop in a later PR
Glen Davies
committed
Lint changes
Glen Davies
committed
Revert "Lint changes"
Glen Davies
committed
Revert "Disable the innerBlocks dropzones so drag drop works same as existing gallery - with the idea that we will improve the innerblocks drag and drop in a later PR"
Glen Davies
committed
Suggested solution for handling multiple file drop into gallery
Glen Davies
committed
Remove non image files from drag and drop and disable individual image drop zone
Glen Davies
committed
Fix transform to individual images
Glen Davies
committed
Fix transform from individual images
Glen Davies
committed
Revert drag and drop transform changes
Glen Davies
committed
Add gallery transform to image block to override the default gallery transform when dragging multiple images onto the gallery
Glen Davies
committed
Move handling of file uploads to Gallery from media placeholder
Glen Davies
committed
split innerblocks mapping into separate effect to reduce chatter
Glen Davies
committed
Add useMemo to currentImageOptions
Glen Davies
committed
reuse existing innerBlocks rather than recreating with every new image selection
Glen Davies
committed
Switch to useMemo for updating local image const instead of local component state
Glen Davies
committed
Fix issue with image sizing not being available on initial load of component some times
Glen Davies
committed
Memoise the useImageSizes hook
Glen Davies
committed
Fix issue with media browser defaulting to edit gallery view
Glen Davies
committed
Fix missed incorrect use of addToGallery
Glen Davies
committed
Add some extra effects for getting the imageData as the getMedia call is async so need to keep circling through the innerblocks updates until we have all the data we need
Glen Davies
committed
Simplify the imageData by using a useSelect
Glen Davies
committed
Another optimisation - only return a new imageData reference if all images have data resolved
Glen Davies
committed
Refactored Gallery: Add loading state to gallery image size options (#27087 )

aaronrobertshaw
authored and
Glen Davies
committed
Initial deprecations commit
Glen Davies
committed
Fix issue with linkDestination not being applied in migration
Glen Davies
committed
Refactor gallery deprecations

aaronrobertshaw
authored and
Glen Davies
committed
Fix missing attributes from migration

aaronrobertshaw
authored and
Glen Davies
committed
Update deprecation to set allowResize

aaronrobertshaw
authored and
Glen Davies
committed
Fix issue with crop not working when certain plugins are loaded
Glen Davies
committed
Fix SCSS lint errors

aaronrobertshaw
authored and
Glen Davies
committed
Update the block example
Glen Davies
committed
Linting fixes
Glen Davies
committed
Fix the e2e test and the accessibility issue with having aria group role on a list item
Glen Davies
committed
Fix the e2e test and the accessibility issue with having aria group role on a list item
Glen Davies
committed
Fix frontend omission of wp-block-image class

aaronrobertshaw
authored and
Glen Davies
committed
change deprecation to use imageCount as isEligible check as it seems that some previous block versions may not have an ids attribute
Glen Davies
committed
Move back to a single deprecations file and reorder in array
Glen Davies
committed
Remove additional check in v5 isEligible
Glen Davies
committed
Fix the v4 migration
Glen Davies
committed
Fix styles for Safari compatibility

aaronrobertshaw
authored and
Glen Davies
committed
Remove unnecessary gallery editor styles

aaronrobertshaw
authored and
Glen Davies
committed
Fix typo in deprecations

aaronrobertshaw
authored and
Glen Davies
committed
Restore styles to render deprecated gallery versions
Glen Davies
committed
Avoid applying flex styles to IE11

aaronrobertshaw
authored and
Glen Davies
committed
Add additional selector to prevent the hidden individual image drop zones ending up display flex instead of hidden
Glen Davies
committed
IE11 styling improvements

aaronrobertshaw
authored and
Glen Davies
committed
Apply default style class to new images added to gallery
Glen Davies
committed
fix linting issues
Glen Davies
committed
Move block props to the outer wrapper
Glen Davies
committed
Revert "Move block props to the outer wrapper"
Glen Davies
committed
Revert "Revert "Move block props to the outer wrapper""
Glen Davies
committed
Fetch media if isListItem is true
Glen Davies
committed
Change context from isListItem to isGrouped
Glen Davies
committed
Remove wrapper div
Glen Davies
committed
remove extra wrapper around media placeholder and caption and use flex css instead
Glen Davies
committed
Revert "remove extra wrapper around media placeholder and caption and use flex css instead
Glen Davies
committed
Revert "Remove external div wrapper by moving InnerBlocks to a fragment"
Glen Davies
committed
another update to image wrapper
Glen Davies
committed
put media uploader outside figure so structure matches front end
Glen Davies
committed
Replace div with View for the sake of native code
Glen Davies
committed
Move setting of attributes to the child images
Glen Davies
committed
Gallery Block Refactor: Account for null image ids in gallery migrations (#27855 )

glendaviesnz
and
Glen Davies
committed
Remove the gradient and put caption under image if is-rounded style applied (#27869 )

glendaviesnz
and
Glen Davies
committed
Remove outer div wrapper
Glen Davies
committed
Keep image margins while dragging sibling

aaronrobertshaw
authored and
Glen Davies
committed
Fix e2e test expected markup to match new structure
Glen Davies
committed
Gallery Block Refactor: Add handling of short code transforms
Glen Davies
committed
Removed unused prop
Glen Davies
committed
Account for undefined block and innerblocks in conversion to reusable block lifecycle
Glen Davies
committed
Add custom gutter sizes to refactored gallery (#28377 )

aaronrobertshaw
authored and
Glen Davies
committed
Adjust editor styles to match new dom structure
Glen Davies
committed
Remove redundant styles that are duplicated in nested image blocks
Glen Davies
committed
Fix issue with Image block dragged out of Gallery still having inheritedAttributes set
Glen Davies
committed
When dragging an image block into a gallery make sure we don't wipe any custom links
Glen Davies
committed
fix issue with variable declaration order
Glen Davies
committed
Fix bug with custom link being overwritten by gallery linkTo changes
Glen Davies
committed
Fix application of gutter size CSS var (#28759 )

aaronrobertshaw
authored and
Glen Davies
committed
Fix mobile width for gallery images

aaronrobertshaw
authored and
Glen Davies
committed
Add missing dependency to inner images selector

aaronrobertshaw
authored and
Glen Davies
committed
remove conversion to cover block if image in gallery
Glen Davies
committed
Add fallback to old gallery edit and save for existing gallery (#28961 )

glendaviesnz
and
Glen Davies
committed
Remove duplicate import
Glen Davies
committed
Remove need for temporary imageUploads attribute as we can just create the innerBlocks as part of transform
Glen Davies
committed
Remove handling of gallery attribute updates from child images
Glen Davies
committed
Move updating of attributes back to gallery and show snackbar to indicated to user that change was made to all images in the gallery
Glen Davies
committed
Update transforms to work with both versions of gallery
Glen Davies
committed
Remove redundant changes
Glen Davies
committed
Remove redundant changes
Glen Davies
committed
Remove unused method
Glen Davies
committed
Merge similar Image transforms.
Glen Davies
committed
Fix some issues missed when moving attribute setting back to gallery.
Glen Davies
committed
Simplify handling of images from media placeholder now that drag and drop files handled by transform
Glen Davies
committed
Fix typo

aaronrobertshaw
authored and
Glen Davies
committed
Fix broken upload from media placeholder
Glen Davies
committed
Fix issue with new file uploads overwriting existing blocks
Glen Davies
committed
Remove isGrouped dependency from call to get image as not needed now attributes handled by gallery
Glen Davies
committed
Remove custom gutter size feature

aaronrobertshaw
authored and
Glen Davies
committed
Use getMediaItems instead of getMedia for getting image data for all gallery images
Glen Davies
committed
Add back missing context prop from rebase conflict
Glen Davies
committed
Make use of new uniqueByBlock flag on updateBlockAttributes to batch child image updates and allow single undo to revert
Glen Davies
committed
Move the setting of the default attributes on new blocks to a single useEffect (#29328 )

glendaviesnz
and
Glen Davies
committed
Add snackbar notice ids (#29364 )

aaronrobertshaw
authored and
Glen Davies
committed
Account for people adding and removing images from media browser so number of images the same, but list of images different to current.
Glen Davies
committed
Changes from PR feedback
Glen Davies
committed
Fix issue with deprecated constants
Glen Davies
committed
Fix linting and e2e test failures
Glen Davies
committed
Some more e2e fixes
Glen Davies
committed
Add transform from old gallery to new format
Glen Davies
committed
Memoize the allowedBlocks

aaronrobertshaw
authored and
Glen Davies
committed
Add warning about image formats required if uploading to gallery
Glen Davies
committed
Move allowedBlocks outside of component to avoid useMemo use

aaronrobertshaw
authored and
Glen Davies
committed
Re-apply uncropped alignment changes lost in rebase
Glen Davies
committed
Fix issue with non-cropped images in deprecated gallery
Glen Davies
committed
Don't show media library buttons while images are still uploading as the media library needs the image ids to reconcile which images are already in the gallery
Glen Davies
committed
Remove gallerRef that was no longer doing anything
Glen Davies
committed
Respect sort order from Media Library (#30070 )

glendaviesnz
and
Glen Davies
committed
Gallery block refactor: make invalid file type errors consistent (#30396 )

committed
Fix issue with invalid type message when adding files via media browser 'Upload' button
Glen Davies
committed
Gallery block refactor: check for new images by clientId instead of id to stop link settings being lost when images edited (#30550 )

glendaviesnz
and
Glen Davies
committed
Apply changes from rebase to deprecated gallery
Glen Davies
committed

Commits on Apr 12, 2021

Apply patch from rebase to not select all items in media library when existing images have no ids
Glen Davies
committed

Commits on Apr 13, 2021

Copy caption across from image selected from media library (#30784 )

glendaviesnz
and
Glen Davies
authored

Commits on Apr 22, 2021

Add data-id to image to help with compatibility of refactored gallery with existing themes and plugins (#30710 )

glendaviesnz
and
Glen Davies
authored

Commits on Apr 23, 2021

Revert "Add data-id to image to help with compatibility of refactored gallery with existing themes and plugins (#30710 )"
Glen Davies
committed
fix bug with image style being lost when gallery grouped (#31068 )

glendaviesnz
and
Glen Davies
authored

Commits on Apr 28, 2021

Only add RichText component if the figcaption is clicked to prevent it stealing focus every time block is selected (#31216 )

glendaviesnz
and
Glen Davies
authored

Commits on Apr 30, 2021

Fix bug with alt text not being copied from media library (#31066 )

glendaviesnz
and
Glen Davies
authored

Commits on May 19, 2021

Merge branch 'trunk' of github.com:WordPress/gutenberg into refactor/gallery-to-nested-image-blocks
Glen Davies
committed

Commits on May 30, 2021

Gallery refactor - Infer version from existing content (#32270 )
mkevins
authored

Commits on Jun 3, 2021

Commits on Jun 9, 2021

Use non-deprecated hook when possible

mkevins
authored and
Glen Davies
committed

Commits on Jun 16, 2021

Commits on Jul 8, 2021

Commits on Jul 16, 2021

Minor changes from code review:
Glen Davies
committed

Commits on Jul 19, 2021

Improve naming of save and deprecated save methods
Glen Davies
committed
Rename __experimentalGalleryRefactor flag to __unstableGalleryWithInnerBlocks
Glen Davies
committed

Commits on Jul 20, 2021

Remove the isGrouped context as no longer needed.
Glen Davies
committed

Commits on Jul 22, 2021

Rename __unstableGalleryWithInnerBlocks to _unstableGalleryWithImageBlocks
Glen Davies
committed

Commits on Jul 26, 2021

Gallery block refactor: remove the imageCount attribute (#33677 )

authored

Commits on Jul 27, 2021

Merge branch 'trunk' of github.com:WordPress/gutenberg into refactor/gallery-to-nested-image-blocks
Glen Davies
committed

Commits on Jul 28, 2021

Fix broken scss
Glen Davies
committed
Fix php linting error
Glen Davies
committed

Commits on Aug 3, 2021

Merge mobile refactor of gallery to nested image blocks into desktop refactor PR(#31306 )

mkevins
and
Antonis Lilis
authored
Merge branch 'trunk' of github.com:WordPress/gutenberg into refactor/gallery-to-nested-image-blocks
Glen Davies
committed

Commits on Aug 9, 2021

Fix issue with upload spinner not displaying correctly on v1 gallery image uploads
Glen Davies
committed

Commits on Aug 12, 2021

Gallery block: Add a filter to automatically convert transforms to and from 3rd party blocks (#33861 )

authored

Commits on Aug 16, 2021

Merge branch 'trunk' of github.com:WordPress/gutenberg into refactor/gallery-to-nested-image-blocks
Glen Davies
committed
Fix issue with image to cover block conversion
Glen Davies
committed

Commits on Aug 17, 2021

Add imageCrop to gallery context
mkevins
committed

Commits on Aug 19, 2021

Fix exceptions caused by useBlocksProps running after block has been deleted. (#34133 )

glendaviesnz
and
Glen Davies
authored