-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Start adding types progressively #26066
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 tasks
Size Change: 0 B Total Size: 1.19 MB ℹ️ View Unchanged
|
ockham
reviewed
Oct 13, 2020
6 tasks
ZebulanStanphill
added
[Package] Components
/packages/components
[Type] Code Quality
Issues or PRs that relate to code quality
labels
Oct 13, 2020
ockham
force-pushed
the
try/start-typing-components
branch
from
October 13, 2020 18:41
251fc7e
to
29cd1b0
Compare
ockham
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
October 13, 2020 19:06
ockham
force-pushed
the
try/start-typing-components
branch
from
October 13, 2020 19:33
29cd1b0
to
51bc244
Compare
ockham
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (pending CI -- I had some trouble trying to restart them in bulk).
sirreal
force-pushed
the
try/start-typing-components
branch
from
October 13, 2020 21:36
51bc244
to
7c390e8
Compare
6 tasks
sirreal
force-pushed
the
try/start-typing-components
branch
2 times, most recently
from
October 14, 2020 08:29
ef7e069
to
f69171b
Compare
sirreal
force-pushed
the
try/start-typing-components
branch
from
October 14, 2020 09:17
f69171b
to
3f14b00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Components
/packages/components
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add types to the
Dashicon
leaf component inpackages/components/
.Part of #18838.
How has this been tested?
Verify that this passes, and that types are being built in
packages/components/build-types/dashicon/
.Screenshots
N/A
Types of changes
Add types
Checklist: