Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] - Buttons block - Support content justification #26166

Merged
merged 1 commit into from
Oct 17, 2020
Merged

[Mobile] - Buttons block - Support content justification #26166

merged 1 commit into from
Oct 17, 2020

Conversation

geriux
Copy link
Member

@geriux geriux commented Oct 15, 2020 •
edited
Loading

Description

This PR is a continuation of #23168 adding support of content justification and the ContentJustificationDropdown for mobile.

How has this been tested?

  • Open the demo app
  • Add a Buttons block
  • Add at least two buttons
  • Select the block
  • Expect to see two options in the Toolbar, Alignment, and Content justification.
  • Change the alignment to full-width
  • Expect to see the block in full-width
  • Change the content justification to different options
  • Expect to see the alignment of the blocks change within the Buttons block

Screenshots

ContentJustificationDropdown ToolbarItem

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@geriux geriux added [Status] In Progress Tracking issues with work in progress Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Oct 15, 2020
@geriux geriux mentioned this pull request Oct 15, 2020
Merged
6 tasks
@github-actions
Copy link

github-actions bot commented Oct 15, 2020 •
edited
Loading

Size Change: 0 B

Total Size: 1.19 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.54 kB 0 B
build/api-fetch/index.js 3.35 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 668 B 0 B
build/block-directory/index.js 8.6 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 130 kB 0 B
build/block-editor/style-rtl.css 10.9 kB 0 B
build/block-editor/style.css 10.9 kB 0 B
build/block-library/editor-rtl.css 8.65 kB 0 B
build/block-library/editor.css 8.65 kB 0 B
build/block-library/index.js 143 kB 0 B
build/block-library/style-rtl.css 7.77 kB 0 B
build/block-library/style.css 7.77 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.78 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.6 kB 0 B
build/components/index.js 169 kB 0 B
build/components/style-rtl.css 15.4 kB 0 B
build/components/style.css 15.4 kB 0 B
build/compose/index.js 9.63 kB 0 B
build/core-data/index.js 12.1 kB 0 B
build/data-controls/index.js 684 B 0 B
build/data/index.js 8.63 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 4.43 kB 0 B
build/edit-navigation/index.js 10.6 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.37 kB 0 B
build/edit-post/style.css 6.35 kB 0 B
build/edit-site/index.js 21.2 kB 0 B
build/edit-site/style-rtl.css 3.81 kB 0 B
build/edit-site/style.css 3.82 kB 0 B
build/edit-widgets/index.js 21.6 kB 0 B
build/edit-widgets/style-rtl.css 3.09 kB 0 B
build/edit-widgets/style.css 3.09 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/index.js 42.4 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.84 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.49 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.54 kB 0 B
build/is-shallow-equal/index.js 709 B 0 B
build/keyboard-shortcuts/index.js 2.39 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.34 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/reusable-blocks/index.js 3.04 kB 0 B
build/rich-text/index.js 13 kB 0 B
build/server-side-render/index.js 2.6 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/url/index.js 4.07 kB 0 B
build/viewport/index.js 1.75 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@ZebulanStanphill ZebulanStanphill force-pushed the update/buttons-block-align-options branch from 67463b4 to 225ff95 Compare October 15, 2020 18:21
ZebulanStanphill
ZebulanStanphill reviewed Oct 15, 2020
View reviewed changes
Copy link
Member

@ZebulanStanphill ZebulanStanphill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures appear to be unrelated and caused by test issues that were present in master (but now fixed, I think). I've rebased #23168, so rebasing this branch should get tests to pass.

I have no way to actually test the code, but just looking at it, I can't see any mistakes. 👍

@geriux geriux force-pushed the rnmobile/buttons-block-align-options branch from cf67f4a to 335d430 Compare October 16, 2020 11:33
@geriux geriux marked this pull request as ready for review October 16, 2020 11:38
@geriux geriux removed the [Status] In Progress Tracking issues with work in progress label Oct 16, 2020
@geriux
Copy link
Member Author

geriux commented Oct 16, 2020

Test failures appear to be unrelated and caused by test issues that were present in master (but now fixed, I think). I've rebased #23168, so rebasing this branch should get tests to pass.

I have no way to actually test the code, but just looking at it, I can't see any mistakes. 👍

Thanks! Just updated the branch

@ZebulanStanphill ZebulanStanphill merged commit 7b3c4fe into update/buttons-block-align-options Oct 17, 2020
@ZebulanStanphill ZebulanStanphill deleted the rnmobile/buttons-block-align-options branch October 17, 2020 04:14
@Tug Tug added the [Type] Bug An existing feature does not function as intended label Oct 20, 2020
ZebulanStanphill pushed a commit that referenced this pull request Oct 21, 2020
@ZebulanStanphill
Mobile - Buttons block - Support content justification and ContentJus…
9e5a534 
…tificationDropdown (#26166)
ZebulanStanphill pushed a commit that referenced this pull request Oct 28, 2020
@ZebulanStanphill
Mobile - Buttons block - Support content justification and ContentJus…
b77c411 
…tificationDropdown (#26166)
ZebulanStanphill added a commit that referenced this pull request Oct 28, 2020
@ZebulanStanphill
Buttons block: overhaul alignment/justification controls (#23168)
a03ea51 
* Buttons block: overhaul alignment/justification controls.

* Make icon names consistent with CSS terminology.

* Move onClick function inline.

* Mobile - Buttons block - Support content justification and ContentJustificationDropdown (#26166)

* Fix control title inconsistency.

Co-authored-by: Gerardo Pacheco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZebulanStanphill ZebulanStanphill ZebulanStanphill left review comments

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geriux @ZebulanStanphill @Tug