Writing flow: consider events only from DOM descendents #27489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -148 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
ellatrix
requested review from
cameronvoell,
etoledom and
guarani
as code owners
ellatrix
added
[Type] Code Quality
ellatrix
commented
Dec 4, 2020
| @@ -9,12 +9,24 @@ import classnames from 'classnames'; | |||
| import { Button } from '@wordpress/components'; | |||
| import { useSelect, useDispatch } from '@wordpress/data'; | |||
| import { useEffect, useRef } from '@wordpress/element'; | |||
| import { BACKSPACE, DELETE } from '@wordpress/keycodes'; | |||
| import { | |||
There was a problem hiding this comment.
Worth noting that everything added to this file is directly copied from WritingFlow. It is not new code.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces #19879.
Other than the benefits of avoiding
stopPropagation, outlined in #19879, it's an opportunity to split writing flow. This PR removes navigation mode logic to the block selection button (displayed in navigation mode), listening for keydown events as close as possible to the source.How has this been tested?
Screenshots
Types of changes
Checklist: