Save editors value on change #27717
Merged
Save editors value on change #27717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -20.6 kB (-2%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Dec 15, 2020
noisysocks
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
This looks good, thanks for fixing. 👍
The only bothersome thing I noticed in my testing is that you get lots of block validation errors in the console while you're typing out a block. But, this isn't really new—it happened before when you blur the textfield. And, I doubt many users type out a block manually.
added 4 commits
January 11, 2021 19:33
…t is not forgotten when a dislpay mode is changed
…nge to editor has been introduced and given throttle time has passed
… setTimeout in index
youknowriad
force-pushed
the
save-editor-value-on-change
branch
from
608fe1f to
eab4a74
Compare
|
Thanks for fixing this longstanding issue!! |
ocean90
reviewed
Jan 20, 2021
| @@ -7,13 +7,14 @@ import Textarea from 'react-autosize-textarea'; | |||
| /** | |||
| * WordPress dependencies | |||
| */ | |||
| import { useSelect } from '@wordpress/data'; | |||
| import * as wp from '@wordpress/data'; | |||
There was a problem hiding this comment.
Yes, it should be removed, useSelect is mocked with jest.mock call in another place. So const useSelect = wp.useSelect; is redundant.
|
It looks like this PR might be causing the issue here: #29988 |
7 tasks
gziolo
pushed a commit
that referenced
this pull request
Apr 6, 2021
gziolo
pushed a commit
that referenced
this pull request
Apr 6, 2021
gziolo
added a commit
that referenced
this pull request
Apr 6, 2021
* revert #27717 (#30524) Co-authored-by: grzim <[email protected]> * Use getAuthors for 'showCombobox' check (#30218) * Use getAuthors for 'showCombobox' check * Add inline comment * Gallery: Set 'addToGallery' prop to false when images don't have IDs. (#30122) This also sets MediaPlaceholder value to an empty object. With both props set to "falsy" values, the gallery media frame is initialized in the "Create Gallery" state. This lets users replace placeholder images from patterns. Co-authored-by: Grzegorz <[email protected]> Co-authored-by: grzim <[email protected]> Co-authored-by: George Mamadashvili <[email protected]>
ntsekouras
pushed a commit
that referenced
this pull request
Apr 7, 2021
* revert #27717 (#30524) Co-authored-by: grzim <[email protected]> * Use getAuthors for 'showCombobox' check (#30218) * Use getAuthors for 'showCombobox' check * Add inline comment * Gallery: Set 'addToGallery' prop to false when images don't have IDs. (#30122) This also sets MediaPlaceholder value to an empty object. With both props set to "falsy" values, the gallery media frame is initialized in the "Create Gallery" state. This lets users replace placeholder images from patterns. Co-authored-by: Grzegorz <[email protected]> Co-authored-by: grzim <[email protected]> Co-authored-by: George Mamadashvili <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolving the issue #9512
The problem was the lack of updates when a user makes a change in an editor but only when the editor lost focus. This was causing situations when users were losing their input when using key shortcuts to change editor mode.
The solution is to add debounced updates after every change made in the editor. The same mechanics are used to save the text as it was done in stopEditting function (which is called when the editor is losing focus).
The function is debounced in order to minimize the number of dispatches.
How has this been tested?
Unit test to cover this case added
Screenshots
Types of changes
Bugfix
Checklist: