Full Site Editing: Update theme attribute injection and removal #28368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeyip
requested review from
mattwiebe,
vindl,
Copons,
david-szabo97 and
Addison-Stavlo
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
6 tasks
Addison-Stavlo
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to @vindl's code review comments in #28088. The functionality introduced by #28088 should not change at all. We're just refactoring the underlying source code and addressing the following comments:
How has this been tested?
Before applying this PR:
wp-content/themes..wp-env.override.json. This creates a copy of the locally installed TT1 theme in an "test" subdirectory in the WordPress volume.npx wp-env startApply this PR:
wp_template_partstt1-blocks/block-templates/front-page.htmlfor example<!-- wp:template-part {"slug":"header","theme":"tt1-blocks","align":"full", "tagName":"header","className":"site-header"} /--><!-- wp:template-part {"slug":"header", "align":"full", "tagName":"header","className":"site-header"} /-->npx wp-env start --updateTypes of changes
Code Refactor
Checklist: