Fix aborted rendering of non-nested reusable blocks #28461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #28405, `render_block_core_block` prevents fatal rendering loops in Reusable Blocks by aborting if a given block has already been rendered. This effectively prevents loops, but also unintentionally prevented the same reusable block from being rendered twice on the same page, even if one isn't nested in the other. This commit fixes this by explicitly forgetting a Reusable Block after it has finished rendering.
mcsf
added
[Type] Bug
This was referenced Jan 25, 2021
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #28405 (comment).
Since #28405,
render_block_core_blockprevents fatal rendering loops in Reusable Blocks by aborting if a given block has already been rendered. This effectively prevents loops, but also unintentionally prevented the same reusable block from being rendered twice on the same page, even if one isn't nested in the other.This PR fixes this by explicitly forgetting a Reusable Block after it has finished rendering, as suggested by @carlomanf.
How has this been tested?
Ensure a reusable block can be used more than once on the same page.
Ensure that recursive reusable blocks are still forbidden.
Types of changes
Bug fix.
Checklist: