Fix regression caused by #28395 #28462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See comment on #28395 (comment)
|
Size Change: -230 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Jan 25, 2021
There was a problem hiding this comment.
Small PR, fast work, fixes the issue. Stellar work 👌
Before, notice the difference in blue spot color:
After:
I'd love for a few more people to test this one just as a sanity check, and because i'm not that deep on this corner of the codebase. It doesn't regress the thing the initial PR was meant to fix, does it?
And note to testers: be sure to stop and restart your npm run dev for the changes to take.
For now though, thanks!
Nope, double-checked the blocks styles and they're OK 👍 |
|
@aristath, we might miss some changes in the build tooling to watch for changes when CSS files change in the block library. |
Yeah, I saw the discussion in the #core-editor channel on Slack and looked at the watch.js file but I couldn't find an issue there... As long as the edited Is there a ticket for that already somewhere? Do you think it could be related to #28395 (and as a result this PR too)? I haven't noticed any weirdness yet so haven't been able to debug the issue properly... |
Maybe it's the change for the watch mode that @youknowriad added in #23998 then? I don't know what the reason is but since CSS was mentioned I could only think about changes to the block library. |
|
Just to note, the primary fix here is to the missing variable in the editing canvas. The buggy npm run dev, I think, was an issue even before these efforts. |
|
Merged this one since it was a pretty small fix and doesn't appear to be related to the npm run dev issue 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment on #28395 (comment)
Description
#28395 caused a small regression. This PR fixes the focus color on selected blocks when using the non-default color-scheme.
How has this been tested?
Midnight.Types of changes
editor-stylesshould not get the vars.Checklist:
My code follows the accessibility standards.My code has proper inline documentation.I've included developer documentation if appropriate.I've updated all React Native files affected by any refactorings/renamings in this PR.cc @jasmussen