Update the documentation - Remove the "theme" key value pair from the block templates #28807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e HTML comment - Removes the "theme" key value pair from the HTML comment of block templates, in the documentation. As per the [recent changes in Gutenberg](WordPress#28088) (as of 9.9) the "theme" attribute should be removed from the template-part blocks.
imranhsayed
requested review from
ajitbohra,
chrisvanpatten and
mkaz
as code owners
gziolo
added
[Type] Developer Documentation
carolinan
reviewed
Feb 7, 2021
docs/designers-developers/developers/tutorials/block-based-themes/README.md
Outdated
Show resolved
Hide resolved
docs/designers-developers/developers/tutorials/block-based-themes/README.md
Outdated
Show resolved
Hide resolved
docs/designers-developers/developers/tutorials/block-based-themes/README.md
Outdated
Show resolved
Hide resolved
Apply suggestions from code review Co-authored-by: Carolina Nymark <[email protected]>
remove unwanted line "If you used a block template part slug, adjust the value for the "slug" key."
|
Thank you @carolinan for the feedback. I have updated the PR as per your request. |
|
@carolinan Please let me know if there are any other changes to be made. |
|
This text is a bit difficult for me to read: |
Update the comment for the block template part slug and value
|
Thanks @carolinan . I have made some changes as per your suggestions. Please let me know if it sounds better now. |
carolinan
approved these changes
Feb 27, 2021
|
Hi, can you refresh this? |
|
Thanks for your work here @imranhsayed! I have to close this PR though as it seems this has been addressed by the massive docs update regarding the creation of a block theme here: #31269. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per the recent changes in Gutenberg (as of 9.9) the "theme" attribute should be removed from the template-part blocks.