[RNMobile] Use BlockEdit component when testing component rendering #29569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlockEdit adds the block edit context, which could be required by some parts of an edit component when it's rendered in a unit test.
fluiddot
added
[Type] Bug
7 tasks
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
|
I've just pushed a couple of changes to debug the |
Looks like the changes have fixed the workflow so I'm going to make a separate PR for those and then update this one. |
Looks good. Can we merge this one and follow up with anything else? |
I'd rather merge the changes in the e2e tests in another PR I've just created to prevent confusion. Once it's approved I'll merge all of them and then we can update your branch. |
|
@guarani I assigned you as a reviewer of the PR I had to create to fix the e2e tests oft this one. Let me know if you have some time to check it, if not we could find someone else to take a look, thanks 🙇 ! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #29442.
Add extra logic to some of the native unit tests that renders blocks:
BlockEditcomponent that will render the block that we want to testThis way, by rendering the edit components from the
BlockEditcomponent, we add the block edit context that could be required by other components when they're rendered.In fact, this is the case when the incoming changes from this PR would be merged, the
RichTexteditor component will require theclientIDproperty that is exposed from a new context that is rendered inBlockEditcomponent.Caveats
My initial approach was to apply this change to all the native unit tests that render edit components but didn't work.
For example in the
Fileblock, one of the tests triggers theonLayouthandler. If we render theBlockEditcomponent, we don't have access to the instance required to trigger that handler so the test fails.I spent some time on finding an alternative but I didn't find any that fits easily. One option I tried was using the
enzymelibrary but when rendering the component via themountfunction,AztecViewgenerates multiple errors. Shallow rendering is not enough because the required handler that we want to trigger is in the children.Probably the best option would be to integrate a more complete library like
@testing-library/react-native, that provides a lot interesting functionality that would make easier to do native unit tests.How has this been tested?
Test with latest changes from
trunkbranchnpm run native test.Test with changes from PR
try/block-context-cleanupfrom the PR.git cherry-pick -n 742eb696556f87707aca0517656d7464ab543bdc.npm run native test.Screenshots
N/A
Types of changes
Bug fix
Checklist: