-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button Block: Removes "Link settings" panel #29664
Button Block: Removes "Link settings" panel #29664
Conversation
Moves "Link rel" into advanced controls.
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Mamaduka! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Thanks for your PR. I also checked if the community documentation needs to be updated and fortunately, the community documentation is out of date and uses the old button block instead of the new 'buttons' block which includes this. I did some very basic tests (create new page, add button - create a link for it; toggle the 'open in new tab' to be active' in the LINK url UI (not in the sidebar), |
Thanks for testing this @skorasaurus. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks for working on this @Mamaduka 💯 and congrats on your first GB PR! Really appreciated!
Thanks, @ntsekouras for the review and for restarting the tests. |
Description
Fixes #23768 by removing the "Link Settings" panel and moving the "Link rel" field into advanced controls.
How has this been tested?
Using
wp-env
package.Screenshots
Types of changes
Checklist: