-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename load_separate_block_styles to load_separate_block_assets #29703
Conversation
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for a quick fix 👍🏻
Do you think it needs some proxy with deprecation in case someone was using the filter?
I don't think so... This was part of FSE so by definition experimental 😄 |
Yes, let's merge as is 👍🏻 |
The failing test is not related to this PR so I'll go ahead and merge it 👍 |
Description
This PR renames a filter and a function from _styles
to
_assets`. These will be used for scripts as well, so their name needs to be less specific and cover both cases.load_separate_block_styles
filter toload_separate_block_assets
gutenberg_should_load_separate_block_styles
function togutenberg_should_load_separate_block_assets
Checklist: