ensure extended settings is hidden when user hides settings sidebar #2972
Conversation
|
My first pr :) Apparently I really need to run tests before I submit a pr. I'll look into the the failing tests... |
Awesome, thanks for on working this issue 👍 You can run tests locally using Travis complains because there are some differences between your code and WordPress code style. One of the unit tests fails because it no longer works with the reducer change you introduced. You can see details here or locally by using the aforementioned commands. It looks like those are mostly tabs vs spaces issues and your editor doesn't support .editorconfig file. On the good side, it all should be easy to fix :) If you have more question don't hesitate to ask :) |
Codecov Report
@@ Coverage Diff @@
## master #2972 +/- ##
==========================================
- Coverage 33.33% 33.32% -0.02%
==========================================
Files 197 197
Lines 5789 5798 +9
Branches 1027 1029 +2
==========================================
+ Hits 1930 1932 +2
- Misses 3254 3259 +5
- Partials 605 607 +2
Continue to review full report at Codecov.
|
|
Just noting that I left some of my own thoughts at #2849 (comment) about whether we'd really want this behavior. |
| @@ -815,7 +815,7 @@ describe( 'state', () => { | |||
| it( 'should apply all defaults', () => { | |||
| const state = preferences( undefined, {} ); | |||
|
|
|||
| expect( state ).toEqual( { blockUsage: {}, recentlyUsedBlocks: [], mode: 'visual', isSidebarOpened: true, panels: { 'post-status': true } } ); | |||
| expect( state ).toEqual( { blockUsage: {}, recentlyUsedBlocks: [], mode: 'visual', isSidebarOpened: true, isExtendedSettingsOpened: true, panels: { 'post-status': true } } ); | |||
| } ); | |||
There was a problem hiding this comment.
Can we add 2 tests that verify changes applied to the reducer when TOGGLE_EXTENDED_SETTINGS action is triggered? It would be very similar to the existing tests for TOGGLE_SIDEBAR_PANEL action.
|
This was fixed in #3065. |
Description
Hides the extended settings if the user hides the settings sidebar. Attempts to fix #2849
Checklist: