Social links, default protocol to https if not set #30100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaz
added
the
[Block] Social
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
|
A follow up fix, I proposed this change in core: https://core.trac.wordpress.org/ticket/52886 This change can still go in prior, and then if/when the core change goes in it will be seamless to switch over. |
mkaz
requested review from
adamsilverstein,
adamziel,
ajitbohra,
ajlende,
atimmer,
cameronvoell,
chrisvanpatten,
dmsnell,
draganescu,
ellatrix,
guarani,
gziolo,
kevin940726,
mmtr,
nerrad,
noisysocks,
oandregal,
ntwb,
spacedmonkey,
swissspidy,
talldan,
tellthemachines and
TimothyBJacobs
as code owners
mkaz
force-pushed
the
update/21699-social-protocols
branch
from
141f4a8 to
1213ae8
Compare
mkaz
removed request for
noisysocks,
talldan,
gziolo,
swissspidy,
ntwb,
ajitbohra,
cameronvoell,
chrisvanpatten,
mmtr,
nerrad,
guarani,
adamsilverstein,
TimothyBJacobs,
ellatrix,
ajlende,
dmsnell,
kevin940726 and
tellthemachines
|
Sorry for inadvertent pings, rebase mishap. 😞 |
7 tasks
If no protocol is specified the core esc_url function will default to http:// protocol, this probably should be updated in core to allow a parameter to default to https See: https://developer.wordpress.org/reference/functions/esc_url/ This change takes the chunk of code from esc_url that determines if needed and defaults to https if no protocol specified. Fixes #21699
mkaz
force-pushed
the
update/21699-social-protocols
branch
from
1213ae8 to
d2b985c
Compare
mkaz
force-pushed
the
update/21699-social-protocols
branch
from
d2b985c to
010b671
Compare
|
@gwwar Kerry can you take a look through this PR? |
gwwar
reviewed
May 28, 2021
| // changed to pass the parameter in esc_url after | ||
| // https://core.trac.wordpress.org/ticket/52886 is in core. | ||
| if ( strpos( $url, ':' ) === false && ! in_array( $url[0], array( '/', '#', '?' ), true ) && | ||
| ! preg_match( '/^[a-z0-9-]+?\.php/i', $url ) ) { |
There was a problem hiding this comment.
Could we add a few unit tests for this? For example, why would we be looking for a .php filename? Are there any other valid protocol-less links that folks would normally enter?
To make this easier to test, we can pull this logic out to a helper function. See example and docs https://developer.wordpress.org/block-editor/contributors/code/testing-overview/#php-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no protocol is specified the core esc_url function will default to http:// protocol, this probably should be updated in core to allow a parameter to default to https
See: https://developer.wordpress.org/reference/functions/esc_url/
This change takes the chunk of code from esc_url that determines if needed and defaults to https if no protocol specified.
Fixes #21699
Testing
Before:
You should see
http://protocol for links with no protocol specifiedAfter:
You should see
https://protocol for links with no protocol specified.Links with protocol specified will be unchanged, so
http://entered will stay ashttp://