Block editor: move is-typing and is-outline-mode classes up the tree #30106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
Mar 22, 2021
| // when the block itself is selected, without it they would also show when a parent block | ||
| // is selected. | ||
| div[data-type="core/freeform"].is-selected &, | ||
| div[data-type="core/freeform"].is-typing & { |
There was a problem hiding this comment.
This rule doesn't do anything. When is-typing was added to a block previously, it would also have the is-selected. It isn't possible for a block to be typed in without it also being selected. This seems like a remnant from old block classes when we would omit the is-selected class when typing in a block to remove the selected styles.
|
Size Change: -30 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/move-is-typing-class
branch
from
a0c0394 to
cef9788
Compare
|
👍 👍 from me, great PR, works as intended, and I tested with navigation mode and while writing. All's good from here. Does it need a code review? Happy to ✅ otherwise. |
|
Thanks for testing, @jasmussen! It's a small change and I just wanted to confirm with you that everything is still working as intended with the CSS adjustments. I'll go ahead and merge. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It doesn't make sense for these classes to be added to blocks. They should be added to the block editor (wrapper). Currently
is-outline-modeis added to every single block in the whole block editor that sets this setting to true. Foris-typing, we have an exception to only add it to the selected block because it would otherwise impact performance negatively.How has this been tested?
In the site editor, the outline should disappear when typing in a block.
Screenshots
Types of changes
Checklist: