Remove italic font-style from large quote block #30530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinyAhin
added
[Block] Quote
|
Size Change: -37 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Style variations are meant to be opinionated, so it's not an issue for me to have opinionated styles in these. That said for this particular one, let's get designer feedback on this PR. |
|
I don't personally have an issue with removing the italic here — It definitely does negate the ability for users to set the text to be italic using the UI controls. I do have a little concern about changing it at this point though: this will definitely adjust the appearance of quotes on the front-end of many existing sites. I'd love a gut check from another designer regarding that concern. |
|
Thanks so much @JustinyAhin for triage through PR — there is literally no better way of moving things forward than that 🏅 I would echo both Kjell and Riad entirely, italic or not is fine. Having opinionated styles is fine too. I would add that the italic on the large quote is block level, whereas the italic button in the toolbar is inline level, which means it actually outputs However one thing you could do is this: What that would do is unset the italic style just for the stuff inside marked italic. I know that seems a little inverted, but I could swear I've seen this before in text editors like Word and Docs, where a preset template style might default to italic, and the explicit button unsetting that. |
Yeah, but that's a weird distinction for users. I think that with upcoming features like #30469, it'll be easy to feature block patterns that use the semantic italic styles here, so it seems fine to remove this. My only concern is just the impact this style removal would have on existing sites. I wonder if a more backwards-compatible approach would be to remove this "Large Quote" block style entirely, but keep the CSS for existing sites. And replace it with a block pattern that works with #30469 instead. |
|
I have nothing to add to the discussion about the technical implementation but would like to add to the conversation that WCAG Understanding Guideline 3.1 includes an advisory technique for “avoiding chunks of italic text”. Similarly, WebAIM advises as follows: “Do not use italics or bold on long sections of text”. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove italic font-style from large quote block
Fixes #22305.
As mentioned in the above issue, styling the
font-styleof large quotes is really opinionated and should be let for themes. Currently, some default WordPress themes already overwrite this in their own styles; so it makes sense to remove it in Gutenberg styles.Checklist:
*.native.jsfiles for terms that need renaming or removal).