-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix metabox reordering #30617
Merged
youknowriad
merged 22 commits into
WordPress:trunk
from
ribaricplusplus:fix/metabox-order
Aug 30, 2021
Merged
Fix metabox reordering #30617
Changes from 7 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
c432edc
Fix metabox reordering
ribaricplusplus 91ca744
Cleanup
ribaricplusplus fe02d17
Merge branch 'trunk' into fix/metabox-order
ribaricplusplus a30bd3c
Cleanup
ribaricplusplus 68e70f4
Formatting
ribaricplusplus d36f3c2
Fix typo
ribaricplusplus eb73aff
Update docs
ribaricplusplus 0ac660d
Merge branch 'trunk' into fix/metabox-order
ribaricplusplus 3a263c6
Formatting
ribaricplusplus 97c3a01
Merge branch 'trunk' into fix/metabox-order
ribaricplusplus bfa0820
Merge branch 'trunk' into fix/metabox-order
ribaricplusplus a24dcbc
Improvements
ribaricplusplus 47ffc13
Don't unsubscribe
ribaricplusplus f86617e
Refactoring
ribaricplusplus 4f67de1
Use useRef instead of useState for initialized variable
ribaricplusplus 521d072
Use useRegistry
ribaricplusplus 9f19aec
Add location dependency
ribaricplusplus 361c2af
Meta boxes must be initialized only once
ribaricplusplus 342361c
Better dispatch check
ribaricplusplus 0d362b8
Add documentation for new action
ribaricplusplus 1d64a78
Better dispatch check
ribaricplusplus c96590a
Rename selector
ribaricplusplus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the coding standards and wondering if this should be returned with the
__unstable
prefix too.What am I missing? This is mainly for my own education rather than an opinion either way :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was following the style established elsewhere in the code where
__unstable
and__experimental
is often removed, for example here:gutenberg/packages/edit-post/src/components/layout/index.js
Lines 17 to 25 in 04c7c76
Also, if I'm not mistaken, it seems that the
__unstable
and__experimental
prefix is there for people using Gutenberg packages in their projects, so it's important not to document these functions and tell people to use them and so forth. Here it's just used locally and not exported anywhere.That's just my reasoning for renaming it, but I'll put the
__unstable
prefix back if you think that would be better.