Alternative approach to adding a close icon for navigation sidebar #31031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
the
[Feature] Site Editor
7 tasks
|
Noting that we could also pursue @jameskoster's approach
In this approach, the |
|
Size Change: +152 B (0%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
|
Thanks so much for exploring these. Out of the two, I have a preference for the existing toggle, even if we add an extra close button affordance to it. Mostly because that lets focus on the W menu "stay in place" rather than shift around when opening closing. If we do go with this alternate approach, we need to consider sites that have a logo defined:
|
You're welcome 👍
I understand this to mean you'd like to retain the toggle interaction in and around the site icon and avoid having a 2nd I see the logic because that would allow the interaction to remain "under" the cursor whether toggling open/closed. In that case we're heading towards simply replacing the site icon with an Shall I do one final exploration of that route? |
|
I'm closing this one based on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alternative approach to #30964 in order to address #29529.
This approach uses a single
NavigationTogglecomponent. It has two states:The site icon (the
Wlogo) is extracted to its ownNavigationIconcomponent and now has no interactivity. It's purely a visual element. You now have to click theXicon to close the panel but that's far more intuitive and is an established pattern in the editor (eg: theList Viewsidebar has this).This approach is better because
Xicon as the way to toggle the panel.See that PR for all details.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).