Keep id on paste if internal link points to it

[juanruitina]

Description

With these changes, the block editor will keep the IDs in links when there's another link pointing to that ID. This is useful when pasting documents with internal links, e.g. when pasting text with footnotes from Microsoft Word, which used to work with the TinyMCE editor. Fixes #12784.

Sometimes internal links leverage the "name" attribute as the anchor instead of "id". However, the use of the name attribute for a elements is obsolete in HTML5; use of id is recommended instead; W3C Markup Validator also shows a warning. This code also saves the name attribute in links as the link's id (unless there's an id attribute already), and then removes it.

(Following @ellatrix feedback in #27677, these changes affect all links, not only footnotes and endnotes)

How has this been tested?

Tested locally with wp-env.

Types of changes

Bug fix

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR. (Doesn't apply)

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @juanruitina! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[juanruitina]

@ellatrix, I accidentally removed the branch I used for #27677, so the PR closed. I took the chance to name the new branch following the developer guidelines. Apologies for the inconvenience.

[ellatrix]

I think we can remove name from the schema.

Otherwise this is great. Simple and generalised so that's really nice.

[ellatrix]

Looks like there's something going wrong with the tests so you might have to rebase to re-run them again at a later time.

[juanruitina]

Thanks a lot @ellatrix for your indications and suggestions, I incorporated them and rebased as suggested. It seems I need approval for rerunning tests, can you do that?

[ellatrix]

@juanruitina You need to rebase to re-run them :)

[ellatrix]

Oh, one last thing, could you add an paste integration test? I think they're in test/integration. You can put the MS Word data in an HTML file like the other tests.

[juanruitina]

@ellatrix Could you provide some more guidance on how could we unwrap text within links with no attributes (therefore with no use)? You mentioned removeInvalidHTML should handle it but I couldn't figure out how we could make sure it achieves that (it doesn't at the moment). It would be nice to clean it up a bit.

[juanruitina]

I added a test in test/integration for the Word paste, seems to work.

(I did something wrong with the rebase and Github automatically asked for reviews from many code owners. I could undo the error, but not those review requests. Sorry for that!!! Geez, I need to get more familiar with git)

[github-actions]

Congratulations on your first merged pull request, @juanruitina! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

[Mamaduka]

Thanks for working on this, @juanruitina, and congratulations on the first merged PR 🎉