fixes issue with site-logo when option is unset #32092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
added
[Type] Bug
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: 0 B Total Size: 1.86 MB ℹ️ View Unchanged
|
aristath
force-pushed
the
fix/site-logo-tweaks
branch
from
e1b74c4 to
e6dc372
Compare
7 tasks
|
Closing this one. It was decided to switch back to using options instead of theme-mods for the site-logo, so this is not relevant to the future of this block. |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The schema for the option had
integerdefined astype. However, when the option is not set, it returnsfalsewhich meant that the REST API validation was failing. This PR allowsbooleanandintegervalues in the response.How has this been tested?
Tested by switching to a theme I haven't used before to make sure the
custom_logotheme-mod is not set, then added a site-logo block in a post.Types of changes
booleanandintegervalues in the API resposereturnto the 2 extra filters we have to avoid breaking other filters that use the same hook.Checklist:
*.native.jsfiles for terms that need renaming or removal).