Try: Fix navigation onselect alignment. #32574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Block] Navigation
|
Size Change: -14 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
carolinan
reviewed
Jun 12, 2021
There was a problem hiding this comment.
This solves the issue for me when I test with block themes.
But I was not able to find a classic theme where the menu items can be aligned correctly to the right in the editor. Because of that I could not test if this PR solves the shift.
It may be theme issues and needs more testing. Themes tested: OceanWP, Twenty sixteen, Twenty Twenty-One.
Tested with 5.8 beta 1 (as in, not the nightly but the released beta 1) in Chrome Version 91.0.4472.101 on Windows 10.
7 tasks
|
Excellent catch, thank you. It's a bit of a more general issue, and I'm trying a fix in #32659 that seems to fix it for me. There are still some themes, like TwentyNineteen, which provide their own child block margins that zero out things here, I'll look at that as a followup. |
7 tasks
|
This PR appears to be unnecessary now that #33088 has landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #32539.
Before:
After:
Note that the previous behavior was "intentional" insofar as the flex container used to have trouble with the in-canvas appender. However revisiting this, things appear to work as they should. Nevertheless, this issue shows just another reason why it'd be good to explore a solution to the in-canvas appender causing layout shifts.
How has this been tested?
The margin applied to the in canvas plus was added to fix problems with flex containers, notably navigation, buttons, social links. Because this PR doubles back on that, it is important to test this with a bunch of themes and a bunch of blocks. At the very least, a block theme and a classic theme, both with navigation and button blocks.
Checklist:
*.native.jsfiles for terms that need renaming or removal).