Image Block: Fix cover block exists check #32666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Block] Cover
|
Size Change: +40 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
mtias
reviewed
Jun 22, 2021
| * | ||
| * @return {boolean} Whether the block exists. | ||
| */ | ||
| function checkBlockExists( name, list ) { |
There was a problem hiding this comment.
If this is formalized in a function, it seems like it belongs in the block/api/registration set and not on the block
There was a problem hiding this comment.
Hi, @mtias
Do you want me to create a new issue for this function?
There was a problem hiding this comment.
I think it'd make sense in order to keep the image block file cleaner. Alternatively, we might want to approach this slightly different and look at getPossibleBlockTransformations instead and not to the block registry.
There was a problem hiding this comment.
Yes relying on the transforms seems to be a really good idea, it may cover other checks that we may be missing. I guess we can rely on the getBlockTransformItems selector.
There was a problem hiding this comment.
Just to be clear, the getPossibleBlockTransformations selector already exists :)
There was a problem hiding this comment.
I agree. Using a transforms selector makes more sense here. Also, we don't have all cases covered yet - #32520.
I will create a new PR that uses getPossibleBlockTransformations if possible or similar logic.
This was referenced Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
coverBlockExistscheck to include checking againstallowedBlockTypeslist.Fixes #32094.
How has this been tested?
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).