-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and backports for WordPress 5.8 RC1 #33036
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The popover is rendered twice, once inside the rich text tag and once outside. One of the popovers is removed when rich text is deselected, but the other is not.
…ock in various editors (#32983) * Remove default left spacing on Latest Posts in all Editors * Remove spacing consistently across Post/Site, Widgets and Widgets Customizer editors * Fix indentation of Comments block in Site Editor
…#33024) * Update logic * RTL and block appender fixes * Fix RTL positioning calculations * Avoid adding wp-block to the appender
* Widgets: Fix creating and editing non-multi widgets * Add regression e2e tests * Lint * Lint * Deactivate gutenberg-test-marquee-widget after test runs Co-authored-by: Adam Zieliński <[email protected]>
youknowriad
requested review from
adamziel,
ajitbohra,
cameronvoell,
chrisvanpatten,
draganescu,
ellatrix,
guarani,
kevin940726,
nerrad,
noisysocks,
ntwb,
talldan and
tellthemachines
as code owners
June 28, 2021 13:04
Size Change: +293 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
It would be good to include #33008. Re-running e2e test because there was an intermittent failure. |
ZebulanStanphill
changed the title
Fixes and backports for WordPress 5.1 RC1
Fixes and backports for WordPress 5.8 RC1
Jun 28, 2021
@ellatrix Sure, I'll wait an hour or so before proceeding here. |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Jun 28, 2021
…Press 5.8 RC1. This includes the fixes from WordPress/gutenberg#33036 See #53397. git-svn-id: https://develop.svn.wordpress.org/trunk@51250 602fd350-edb4-49c9-b593-d223f7449a82
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this pull request
Jun 28, 2021
…Press 5.8 RC1. This includes the fixes from WordPress/gutenberg#33036 See #53397. git-svn-id: https://develop.svn.wordpress.org/trunk@51250 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jun 28, 2021
…Press 5.8 RC1. This includes the fixes from WordPress/gutenberg#33036 See #53397. Built from https://develop.svn.wordpress.org/trunk@51250 git-svn-id: http://core.svn.wordpress.org/trunk@50859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Jun 28, 2021
…Press 5.8 RC1. This includes the fixes from WordPress/gutenberg#33036 See #53397. Built from https://develop.svn.wordpress.org/trunk@51250 git-svn-id: https://core.svn.wordpress.org/trunk@50859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
F-Wilke
pushed a commit
to FiliagoDev/WordPress
that referenced
this pull request
Jul 31, 2021
…Press 5.8 RC1. This includes the fixes from WordPress/gutenberg#33036 See #53397. Built from https://develop.svn.wordpress.org/trunk@51250 git-svn-id: http://core.svn.wordpress.org/trunk@50859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It includes