[Widgets editor] Replace the "technical" error notice a more user-friendly one #33165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Feature] Widgets Screen
adamziel
changed the title
|
Size Change: +80 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
draganescu
added
Needs Copy Review
|
I would phrase as "Some blocks" instead of "The following blocks". |
getdave
approved these changes
Jul 2, 2021
|
I went ahead and merged, happy to update the phrasing if needed. |
This phrasing works well! Just to clarify, if multiple blocks are affected, will the wording slightly change ("were affected")? |
noisysocks
added
the
Backport to WP 6.7 Beta/RC
For now we'll show multiple notices. I'd like to have that all "flattened" to just a single message eventually, but it is not a case ATM. |
youknowriad
pushed a commit
that referenced
this pull request
Jul 5, 2021
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 6, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I believe that, besides its technical aspects, Trac #53437 is largely a communication problem. We need to somehow tell the user that the error happened, but saying wp.editor.initialize is not a function or dropping any other error message isn't very helpful to the user.
We could just disable the affected widgets, but we still need to communicate it, it’s just the wording would be more like "The following blocks (...) have been disabled".
Two things this PR is missing are:
Blocks 'text' and 'plugin/cool-editor' were affected...) –Before – a cryptic message and no stack trace:
After – an informative message + a relevant stack trace logged in the console:
How has this been tested?
Types of changes
Bug fix