Increase specificity of the NoPreview CSS rules to avoid conflicts with theme styles #33200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Feature] Widgets Screen
adamziel
changed the title
|
Size Change: +38 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Jul 5, 2021
| @@ -114,10 +114,15 @@ | |||
| width: 100%; | |||
| } | |||
|
|
|||
| .wp-block-legacy-widget__edit-no-preview { | |||
| .wp-block-legacy-widget__edit-no-preview.wp-block-legacy-widget__edit-no-preview.wp-block-legacy-widget__edit-no-preview { | |||
There was a problem hiding this comment.
I have seen this pattern more and more often :) Repeating classname syndrome. I guess it's the only way? (At least this is the constant answer).
There was a problem hiding this comment.
I don't like it either, but unfortunately it seems so – it's just the charm of applying theme styles in an environment where we have a bunch of other stylesheets already. Maybe some planning and a major refactor of how we work with the styles would spare us doing this in the future (maybe), but I can't see a simple solution.
adamziel
added
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Jul 6, 2021
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 6, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the
use theme stylesoption is enabled, legacy widget block styles are getting overridden by the theme styles. In particular, one offending CSS rule is.editor-styles-wrapper p. As a result, the "preview unavailable" component ends up looking like this:This PR tweaks the selector specificity, which makes for a final effect like this:
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)