Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counter class on post-comments-counter block #34043

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

sagarnasit
Copy link

@sagarnasit sagarnasit commented Aug 12, 2021

Description

PR updates post-comment-count block to add the class with the current comment counter.

For example, A post has 10 comments then the block will have a class with comments count comments-count-10.

Issue: #24953 (comment)

How has this been tested?

Make sure unit tests are passing for the block-library:

npm run test-unit packages/block-library/src/**/test

Screenshots

image

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@sagarnasit sagarnasit requested a review from ajitbohra as a code owner August 12, 2021 13:02
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sagarnasit! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Aug 12, 2021
@skorasaurus skorasaurus added the [Block] Post Comments Count Affects the Post Comments Count Block label Jan 13, 2022
@carolinan
Copy link
Contributor

Hi @sagarnasit Are you available to refresh this pull request?

Copy link

github-actions bot commented Dec 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sagarnasit <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@sagarnasit
Copy link
Author

Hi @carolinan, I have synced the pull request with the trunk. Let me know how I can assist further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Comments Count Affects the Post Comments Count Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants