Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border controls: add base styles #34131

Closed
wants to merge 4 commits into from
Closed

Border controls: add base styles #34131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f276cca
Add base styles for border
stacimc Aug 18, 2021
cd98230
Remove border style from default controls
stacimc Aug 18, 2021
73f72f3
Fix selector for frontend css
stacimc Aug 18, 2021
c5a1b80
Fix frontend styles for blocks where wp-block is not the first classname
stacimc Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/block-library/src/common.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,3 +89,10 @@
width: auto;
z-index: 100000;
}

// The following sets baseline border styles with zero specificity such that
// when a user begins to alter block borders via the block support UI they
// see immediate visual changes.
html :where([class*="wp-block"]) {
border: 0 solid currentColor;
}
7 changes: 7 additions & 0 deletions packages/block-library/src/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,13 @@
font-size: 42px;
}

// The following sets baseline border styles with zero specificity such that
// when a user begins to alter block borders via the block support UI they
// see immediate visual changes.
html :where(.wp-block) {
border: 0 solid currentColor;
}

/**
* Editor Normalization Styles
*
Expand Down
1 change: 0 additions & 1 deletion packages/block-library/src/group/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
"__experimentalDefaultControls": {
"color": true,
"radius": true,
"style": true,
"width": true
}
},
Expand Down
1 change: 0 additions & 1 deletion packages/block-library/src/pullquote/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
"__experimentalDefaultControls": {
"color": true,
"radius": true,
"style": true,
"width": true
}
}
Expand Down
1 change: 0 additions & 1 deletion packages/block-library/src/table/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@
"width": true,
"__experimentalDefaultControls": {
"color": true,
"style": true,
"width": true
}
},
Expand Down