i18n: Add context to 'none' strings for better translations #34341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom #22095 This is because "None" can be translated differently in languages other than English depending on the context.
ramonjd
added
Internationalization (i18n)
ramonjd
requested review from
apeatling,
glendaviesnz,
andrewserong,
aaronrobertshaw and
stacimc
ramonjd
requested review from
ajitbohra,
chrisvanpatten and
mkevins
as code owners
6 tasks
|
Size Change: +186 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
Thanks for picking up this one @ramonjd! I did a quick smoke test that there were no errors in the editor, and all the context strings read well to me. LGTM! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a revival of #22095 which adds context to "None" strings, which can, depending on the context, be translated differently in languages other than English.
This changeset replaces
__( 'None' )occurrences with_x( 'None', 'Some context ), as well as implementing other suggestions made by reviewers in #22095.Props to @audrasjb for the original PR.
Grazie! Thank you! Danke! Xièxie! Shukran!
Types of changes
Non-breaking i18n change
Testing
Check syntax and context comprehensibility
Checklist:
*.native.jsfiles for terms that need renaming or removal).