Tools: Update TypeScript to the 4.4.x version #34373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Code Quality
gziolo
requested review from
sarayourfriend,
sirreal,
ciampo,
jsnajdr,
youknowriad and
a team
|
I would appreciate some help with addressing all the reported errors. |
|
It looks like there is more strict handling in https://devblogs.microsoft.com/typescript/announcing-typescript-4-4/#use-unknown-catch-variables |
gziolo
commented
Aug 30, 2021
| debug( | ||
| `first-time-contributor-account-link: Error retrieving from profile API:\n\n${ error.toString() }` | ||
| ); | ||
| if ( error instanceof Error ) { |
There was a problem hiding this comment.
The question is whether request throws an Error instance.
There was a problem hiding this comment.
It may be better to change the original promise so that it creates a new error when rejecting:
reject(new Error('fail'))
There was a problem hiding this comment.
error.toString() would print fail in that case.
I came up with a simpler solution. I added a check if error is an object which should be general enough and ensure there is toString method present 😄
2 tasks
|
Took a look at the
I presume we still want to use it if the browser supports it (cc @ellatrix ). Is there a way to tell TypeScript not to report some error? |
|
Thanks for the notes @oandregal!
I pushed a fix for this in b4636c1. Basically it restores the type that was removed. I've pushed commits for type issues as they manifested. There were a number of issues with Reakit types so I ended up disabling type checks for external libs ( |
There's an open PR to fix that on Reakit (ariakit/ariakit#903). I'll take a look at that and I hope it gets merged this week. |
|
For better visibility, CI issues are unrelated to these changes. More details in #34377. |
gziolo
force-pushed
the
update/typescript-4.4
branch
from
092cb5b to
7b193fb
Compare
|
I rebased this branch with the latest changes applied to Thank you all for your help and kudos to @sirreal for all fixes applied. I'm going to land this when CI turns green. |
gziolo
requested review from
ellatrix,
nerrad,
ntwb and
swissspidy
as code owners
gziolo
commented
Sep 1, 2021
| @@ -28,8 +28,9 @@ export function sprintf( format, ...args ) { | |||
| try { | |||
| return sprintfjs.sprintf( format, ...args ); | |||
| } catch ( error ) { | |||
| logErrorOnce( 'sprintf error: \n\n' + error.toString() ); | |||
|
|
|||
| if ( error instanceof Error ) { | |||
There was a problem hiding this comment.
This one is good, sprintfjs throws only Error instances:
|
Size Change: +77 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
Yes we need to keep it. See https://developer.mozilla.org/en-US/docs/Web/API/Document/caretRangeFromPoint. |
gziolo
commented
Sep 1, 2021
| * | ||
| * @return {boolean} Whether error is a duplicate validation request error. | ||
| */ | ||
| const isDuplicateValidationError = ( requestError ) => { | ||
| // The included version of RequestError provides no way to access the | ||
| // full 'errors' array that the github REST API returns. Hopefully they | ||
| // resolve this soon! | ||
| return requestError.message.includes( 'already_exists' ); | ||
| const errorMessage = /** @type {undefined | null | {message?: string}} */ ( requestError ) |
There was a problem hiding this comment.
It looks like it errors in the GitHub action:
https://github.com/WordPress/gutenberg/runs/3482847233
I will try to find a quick fix.
gziolo
added a commit
that referenced
this pull request
Sep 1, 2021
…-automation` Follow-up for #34373.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See: https://devblogs.microsoft.com/typescript/announcing-typescript-4-4/
There is
118 errors to fix reported after runningnpm run clean:package-typesandnpm run build:package-types:How has this been tested?
npm run clean:package-typesnpm run build:package-typesTypes of changes