[RNMobile][Embed block] Enable embed preview for a list of providers #34446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
…ed-block-enable-preview-by-providers
fluiddot
commented
Sep 1, 2021
| @@ -111,19 +111,16 @@ const EmbedPreview = ( { | |||
| disabled={ ! isSelected } | |||
| > | |||
| <View> | |||
| { | |||
| // eslint-disable-next-line no-undef | |||
| __DEV__ && previewable ? ( | |||
There was a problem hiding this comment.
The inline preview feature is no longer limited to development mode so after this PR gets merged the feature will be available in production for the specified providers.
7 tasks
ceyhun
approved these changes
Sep 1, 2021
| @@ -10,7 +10,7 @@ For each user feature we should also add a importance categorization label to i | |||
| --> | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| - [**] Enable embed inline previews (for now only YouTube and Twitter will be available) [#34447] | |||
There was a problem hiding this comment.
Oh good catch 😅 , I merged the changes but I forgot to update this entry, I'll update it asap.
There was a problem hiding this comment.
I updated the changelog in this commit.
|
I'm a bit confused about why the job "Static Analysis (Linting, License, Type checks...)" is failing 🤔 , the error is unrelated to these changes so I'm wondering if it has to do with recent changes from Error: |
fluiddot
changed the title
fluiddot
deleted the
rnmobile/embed-block-enable-preview-by-providers
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3900Description
Add a static list of providers for which the embed inline preview will be available.
The providers that will enable the inline preview are:
NOTE: This PR also enables the inline previews feature to all users.
How has this been tested?
YouTube and Twitter providers display the inline preview
Other providers display the coming soon message
Screenshots
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).