Block Editor: Migrate lightBlockWrapper support to apiVersion for blocks
#34459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Package] Block editor
|
Size Change: +49 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/block-editor-compat-hook
branch
from
f1e0864 to
8f277aa
Compare
7 tasks
gziolo
force-pushed
the
update/block-editor-compat-hook
branch
from
8f277aa to
4783187
Compare
gwwar
reviewed
Sep 1, 2021
There was a problem hiding this comment.
So reading #27189 it sounds we gate functionality via the API version 2 check or supports: { lightBlockWrapper: true }
On this branch, and I'm seeing the following error. Trunk works as expected to register the block type. Let me know if y'all see this too.
|
@gwwar, I can reproduce the issue now. I will investigate 👍🏻 I applied some code changes after I made screenshots so I'm curious what could possibly go wrong 😄 |
gziolo
force-pushed
the
update/block-editor-compat-hook
branch
from
4783187 to
9bcde92
Compare
|
I hope I fixed all my mistakes in 9bcde92 😅 |
gwwar
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for https://github.com/WordPress/gutenberg/pull/34346/files#r697287973:
The change refactors code to no longer use
lightBlockWrappercheck for block types and instead migrates this removedsupportsfield toapiVersion2 if the version is lower than 2.The rationale behind the proposed change is to simplify checks in the codebase.
How has this been tested?
The most popular use case can be tested in the Browser Console:
Types of changes
Code quality change.
Checklist:
*.native.jsfiles for terms that need renaming or removal).