Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DuotonePicker docs for accuracy #34494

Merged

Conversation

madalingorbanescu
Copy link
Contributor

Description

Fixes the DuotonePicker docs.

  • Added missing , for DUOTONE_PALETTE objects properties.
  • Replaced COLOR_PALETTE colors property to color according to the API.

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @madalingorbanescu! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 2, 2021
Copy link
Contributor

@ajlende ajlende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! It looked like the color in the color palette should also just be a string, so I added a commit for that.

@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Sep 3, 2021
@getsource getsource merged commit e020354 into WordPress:trunk Sep 7, 2021
@github-actions
Copy link

github-actions bot commented Sep 7, 2021

Congratulations on your first merged pull request, @madalingorbanescu! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 11.5 milestone Sep 7, 2021
@getsource
Copy link
Member

Thanks so much @madalingorbanescu and @ajlende !

@getsource getsource changed the title Fix DuotonePicker docs Update DuotonePicker docs for accuracy Sep 7, 2021
@getsource getsource added the [Package] Components /packages/components label Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants