Replace tinycolor2 with colord on contrast checker. #34605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Code Quality
3 tasks
|
Apart from the failing CI tests this change looks good to me. It tested well on local dev site and color contrast message displayed as expected. The unit tests for this component also passed locally for me. Happy to give it a ✅ if needed when the CI failures fixed. |
jorgefilipecosta
force-pushed
the
add/replace-tinycolor2-with-colord-on-contrast-checking-component
branch
from
9d7f578 to
c9fa7cb
Compare
jorgefilipecosta
force-pushed
the
add/replace-tinycolor2-with-colord-on-contrast-checking-component
branch
from
c9fa7cb to
356dd8b
Compare
|
Size Change: +3.88 kB (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Thank you for the review @glendaviesnz there was a listing issue that was fixed. Now the remaining failure is an issue with react native tests that we also have in the trunk so I'm going for the merge. |
jorgefilipecosta
deleted the
add/replace-tinycolor2-with-colord-on-contrast-checking-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #34286.
This PR replaces the tinycolor2 library with colord on the contrast checking component.
How has this been tested?
I added a paragraph block and tried some text and background color combinations. I verified the contrast warnings appear when expected.