[Mobile] - Image block - Fix height and border regression #34957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Status] In Progress
|
Size Change: 0 B Total Size: 1.06 MB ℹ️ View Unchanged
|
3 tasks
antonis
approved these changes
Sep 20, 2021
5 tasks
enejb
pushed a commit
that referenced
this pull request
Sep 24, 2021
* Mobile - Fix Image block height regression * Mobile - Image block - Check context exists
enejb
pushed a commit
that referenced
this pull request
Sep 24, 2021
* Mobile - Fix Image block height regression * Mobile - Image block - Check context exists
5 tasks
geriux
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Mobile - Fix Image block height regression * Mobile - Image block - Check context exists
7 tasks
geriux
pushed a commit
that referenced
this pull request
Sep 28, 2021
* Release script: Update react-native-editor version to 1.61.0 * Release script: Update with changes from 'npm run core preios' * Update changelog * Release script: Update react-native-editor version to 1.61.1 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Show always the symbol icon in the block picker for reusable blocks (#34873) In case the reusable block only contains a single block, the icon of that block is used when presenting the reusable block in the block picker. This change limits this behaviour to the web version of the editor, so now in the native version, it will always use the symbol icon. Co-authored-by: Antonis Lilis <[email protected]> * Update react-native-editor changelog * Release script: Update react-native-editor version to 1.61.2 * Release script: Update with changes from 'npm run core preios' * [Mobile] - Image block - Fix height and border regression (#34957) * Mobile - Fix Image block height regression * Mobile - Image block - Check context exists * Mobile - Update changelog Co-authored-by: Antonis Lilis <[email protected]> Co-authored-by: Matthew Kevins <[email protected]> Co-authored-by: Carlos Garcia <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#3987
Description
This PR fixes a regression in the Image block introduced by these changes. Causing the images to have a fixed height and not adjusting correctly, as well as making the border settings to not work as expected.
How has this been tested?
Test case 1 - Image block
Test case 2 - Gallery block
Precondition: Make sure to have enabled the
__unstableGalleryWithImageBlocksflag.Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).