Fix block gap added to the block templates skip link #34986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
aristath
approved these changes
Sep 21, 2021
aristath
added
the
Backport to WP 6.7 Beta/RC
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this pull request
Nov 25, 2021
Fix Twenty Twenty-one having an erroneous margin above the Header template part by moving the skip link outside of the wp-site-blocks canvas. This is a backport of WordPress/gutenberg#34986. Props youknowriad. Fixes #54491. git-svn-id: https://develop.svn.wordpress.org/trunk@52243 602fd350-edb4-49c9-b593-d223f7449a82
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Nov 25, 2021
Fix Twenty Twenty-one having an erroneous margin above the Header template part by moving the skip link outside of the wp-site-blocks canvas. This is a backport of WordPress/gutenberg#34986. Props youknowriad. Fixes #54491. git-svn-id: https://develop.svn.wordpress.org/trunk@52243 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Nov 25, 2021
Fix Twenty Twenty-one having an erroneous margin above the Header template part by moving the skip link outside of the wp-site-blocks canvas. This is a backport of WordPress/gutenberg#34986. Props youknowriad. Fixes #54491. Built from https://develop.svn.wordpress.org/trunk@52243 git-svn-id: http://core.svn.wordpress.org/trunk@51835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Nov 25, 2021
Fix Twenty Twenty-one having an erroneous margin above the Header template part by moving the skip link outside of the wp-site-blocks canvas. This is a backport of WordPress/gutenberg#34986. Props youknowriad. Fixes #54491. Built from https://develop.svn.wordpress.org/trunk@52243 git-svn-id: https://core.svn.wordpress.org/trunk@51835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trunk the skip link is added inside the
wp-site-blocksdiv dynamically but that container block has "block gap" styles meaning the hidden link will have a visible "margin" added to separate from the other elements using the block gap config.To avoid this conflict, this PR moves to the skip link outside the
wp-site-blocksTesting instructions
mainarea.