Block Editor: fix duplicate clientIds when dragging patterns #35124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwwar
added
[Type] Bug
|
Size Change: -300 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
fabiankaegy
reviewed
Sep 27, 2021
There was a problem hiding this comment.
I checked this out locally and confirmed the issue and the fix. Dragging patterns into the editor now works as expected giving each inserted block a unique clientId.
The code also looks good to me but I will leave the approval to a code owner more familiar with the functionality :)
youknowriad
reviewed
Sep 27, 2021
packages/block-editor/src/components/inserter-draggable-blocks/index.js
Outdated
Show resolved
Hide resolved
youknowriad
approved these changes
Sep 27, 2021
|
Thanks for the reviews @youknowriad @fabiankaegy ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35120 where dragging patterns multiple times will insert blocks with duplicate clientIds. This isn't a problem for onClick since we explicitly clone the blocks in that case.
If we don't like the code approach here, one alternative is always cloning for the 'inserter' case since we never intend to add duplicate clientIds. (It happens to work for the inserter drag currently since it re-renders that often).
Step-by-step reproduction instructions
wp.data.select('core/block-editor').getBlocks()Before:
CleanShot.2021-09-24.at.10.07.55.mp4
After:
CleanShot.2021-09-24.at.10.07.55.mp4