Edit Site: Optimize useSelect calls #35213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Package] Edit Site
youknowriad
approved these changes
Sep 29, 2021
|
Size Change: +1 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
|
I will try to create similar PRs per package basis to make reviews easier. @youknowriad, what’s the good use case for omitting |
|
@Mamaduka I guess sometimes running the selector is quicker than memoization maybe but in reality, I don't think there's any. |
|
Thanks, I want to make sure I don't add dependency array where it was intentionally left out. The lint rule will also help in these cases since one will have to add a comment to disable the warning. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds missing dependency arrays to
useSelectcalls to memorize selector callbacks in the@wordpress/edit-sitepackage.Similar PR #23255.
How has this been tested?
The site editor works as expected.
Types of changes
Code Quality/Perfromance
Checklist:
*.native.jsfiles for terms that need renaming or removal).