Gallery block: fix Safari image sizing issue #35309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
the
[Block] Gallery
|
Size Change: +4 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Oct 3, 2021
There was a problem hiding this comment.
Thanks for the fix @glendaviesnz!
Confirmed the issue was present in Safari desktop, but not Chrome. The fix resolves the styling in Safari, and doesn't cause any issues in the other browsers I tested with (FF, Edge, Chrome) 👍
| Before | After |
|---|---|
 |
 |
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A css width setting was inadvertently removed when the IE specific css hacks were removed. This is causing Safari to set the wrong image height in the deprecated Gallery block when the images are linked to media or attachment.
Fixes: Automattic/wp-calypso#56555
Testing
attachmentormedia, and images tocroppedScreenshots
Before:
After:
